villebro opened a new pull request #10299:
URL: https://github.com/apache/incubator-superset/pull/10299


   ### SUMMARY
   Introduce case insensitive validation of filter operators in chart data 
schemas. custom validators are moved to `utils/schema.py` as they will likely 
be relevant in other nedpoints, too.
   
   Currently the cases of filter operators are inconsistent: some are all 
uppercase, others all lowercase. I considered unifying those, but it would have 
introduced risk of regression, so will save that for a separate PR after 0.37.0 
has shipped.
   
   ### BEFORE
   
![image](https://user-images.githubusercontent.com/33317356/87283575-19189480-c4fe-11ea-993a-d3a58562d32c.png)
   ### AFTER
   <!--- Skip this if not applicable -->
   
![image](https://user-images.githubusercontent.com/33317356/87283443-f8e8d580-c4fd-11ea-9891-7d009bca778d.png)
   
   ### TEST PLAN
   CI + new tests
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue: closes #10296 
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to