[GitHub] [incubator-superset] nytai opened a new pull request #10298: feat: SIP-34 Bulk Select

[GitBox]

nytai opened a new pull request #10298:
URL: https://github.com/apache/incubator-superset/pull/10298


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   - Add SIP-34 Bulk select to DatasetList DashboardList, ChartList
   - convert Button.jsx -> Button.tsx (& add styling for `supersetButton`)
   - refactor SubMenu to be presentation only, moving DatasetAddModal to 
DatasetsList
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   #### Datasets
   <img width="3008" alt="Screen Shot 2020-07-12 at 10 09 06 PM" 
src="https://user-images.githubusercontent.com/10255196/87273357-bab3cd80-c48d-11ea-88a2-080fd8a9c32e.png";>
   <img width="3007" alt="Screen Shot 2020-07-12 at 10 09 21 PM" 
src="https://user-images.githubusercontent.com/10255196/87273383-d1f2bb00-c48d-11ea-9c5f-6f668c983900.png";>
   
   #### Charts
   <img width="3008" alt="Screen Shot 2020-07-12 at 10 10 24 PM" 
src="https://user-images.githubusercontent.com/10255196/87273389-d6b76f00-c48d-11ea-9622-8e77086c66b4.png";>
   
   #### Dashboards
   <img width="3008" alt="Screen Shot 2020-07-12 at 10 09 44 PM" 
src="https://user-images.githubusercontent.com/10255196/87273388-d5864200-c48d-11ea-9d23-d09798eaffa5.png";>
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   - bulk select delete works for Datasets, Charts, Dashboards
   - bulk expect works for Dashboards
   - Dataset Add flow works
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI: Behind `ENABLE_REACT_CRUD_VIEWS` config flag
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org