Steejay commented on a change in pull request #10274:
URL:
https://github.com/apache/incubator-superset/pull/10274#discussion_r454462472
##########
File path: superset/errors.py
##########
@@ -46,6 +47,23 @@ class SupersetErrorType(str, Enum):
DATASOURCE_SECURITY_ACCESS_ERROR = "DATASOURCE_SECURITY_ACCESS_ERROR"
MISSING_OWNERSHIP_ERROR = "MISSING_OWNERSHIP_ERROR"
+ # Other errors
+ BACKEND_TIMEOUT_ERROR = "BACKEND_TIMEOUT_ERROR"
+
+
+ERROR_TYPES_TO_ERROR_CODES_MAPPING = {
+ SupersetErrorType.BACKEND_TIMEOUT_ERROR: [
+ {
+ "code": 1000,
+ "message": _("Error 1000 - The datasource is too large to query."),
+ },
+ {
+ "code": 1001,
+ "message": _("Error 1001 - The database is under an unusual
load."),
+ },
+ ]
+}
Review comment:
Yup, I think this is a great analogy @etr2460
The renaming suggestion is an interesting idea and worth considering. I
wonder if renaming to "Issue" instead would make more sense?
This may be triggered by:
Issue 1000 - The datasource is too large to query
Issue 1001 - The database is under an unusual load
The statement "The datasource is too large to query" implies an issue. Not
necessarily a cause or source of anything until applied to the context of this
specific alert message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
