etr2460 commented on pull request #10274: URL: https://github.com/apache/incubator-superset/pull/10274#issuecomment-661152340
@graceguo-supercat and @ktmud, sorry for the delayed response here. I think this is in a good place for final review now. Some significant changes from before: - I've moved all issue strings from the frontend to the backend, so any client can generate appropriate error messages from the payload returned - I'm using the `@handle_api_error` wrapper on the backend to construct the appropriate error response when sql queries timeout. This seems to be the standard approach thus far and aligns with how `SupersetSecurityException` is handled in the new error format. Completely changing the handling methods on the backend seems out of scope here, but I'm going to move the conversation we had into SIP-41 as it seems quite pertinent to it - Error Codes have been renamed to Issue Codes as that wording seems more clear  Thanks for taking the time to be diligent here and get this PR into a better state than it started. Hopefully it should be good to go! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
