kristw commented on a change in pull request #10317:
URL:
https://github.com/apache/incubator-superset/pull/10317#discussion_r455241171
##########
File path: superset-frontend/src/welcome/DashboardTable.tsx
##########
@@ -17,35 +17,45 @@
* under the License.
*/
import React from 'react';
-import PropTypes from 'prop-types';
import { t } from '@superset-ui/translation';
import { SupersetClient } from '@superset-ui/connection';
import moment from 'moment';
import { debounce } from 'lodash';
import ListView from 'src/components/ListView/ListView';
import withToasts from 'src/messageToasts/enhancers/withToasts';
+import { Dashboard } from 'src/types/bootstrapTypes';
+import { FetchDataConfig } from 'src/components/ListView/types';
const PAGE_SIZE = 25;
-class DashboardTable extends React.PureComponent {
- static propTypes = {
- addDangerToast: PropTypes.func.isRequired,
- search: PropTypes.string,
- };
+interface DashboardTableProps {
Review comment:
Generally, when the call can go either way (both with pros/cons or none
have good reasons), I would lean on consistency if it is not expensive change
and no clear win. Otherwise the entire codebase will have many different
dialects. That is probably worse.
If you think the benefit above is not convincing enough and the majority in
this repo is already using `interface`, we can also start documenting these
decisions for `incubator-superset`, and adopt `interface` for this repo.
For the internal Airbnb project, I'll stick to the TS style guide from the
TS working group.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
