ktmud commented on a change in pull request #10317:
URL:
https://github.com/apache/incubator-superset/pull/10317#discussion_r455406730
##########
File path: superset-frontend/src/welcome/DashboardTable.tsx
##########
@@ -58,6 +68,13 @@ class DashboardTable extends React.PureComponent {
row: {
original: { url, dashboard_title: dashboardTitle },
},
+ }: {
+ row: {
+ original: {
+ url: string;
+ dashboard_title: string;
+ };
+ };
Review comment:
Sorry for missing this earlier, but I think all `Cell` renderers
actually have the same signature.
`react-table` has typing for its parameters, so this should probably be
refactored as:
```ts
import { Column } from 'react-table'
interface DataboardRecord {
url: string;
dashboard_title: string;
changed_on: string;
changed_by_name: string;
changedByUrl: string;
}
columns: Column<DataboardRecord>[] = [{
...
Cell: ({ row: { original: { ... } } }) => ...
}]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
