[GitHub] [incubator-superset] nytai opened a new pull request #10335: feature: enabled SIP-34 listview filters for react CRUD

[GitBox]

nytai opened a new pull request #10335:
URL: https://github.com/apache/incubator-superset/pull/10335


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   - api endpoint `/api/v1/database/schemas` for fetching list of schemas.
   - adds SIP-34 filters to datasets list view
   - removes `LIST_VIEWS_SIP34_FILTER_UI` feature flag
   - enabled SIP-34 filters for datasts, charts, dashboards, listview
   - moves `src/views/*` -> `src/views/CRUD/*` (eg, 
`src/views/datasetList/DatasetList.tsx` -> 
`src/views/CRUD/dataset/DatasetList.tsx` ) -- idea being that `src/views/CRUD` 
namespace can share code, ie, data fetching logic, state hooks, edit modals, 
delete modals, etc
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   <img width="843" alt="Screen Shot 2020-07-15 at 6 46 41 PM" 
src="https://user-images.githubusercontent.com/10255196/87617693-da850480-c6cc-11ea-9a66-a97a342c8c63.png";>
   <img width="3008" alt="Screen Shot 2020-07-15 at 6 46 49 PM" 
src="https://user-images.githubusercontent.com/10255196/87617696-dbb63180-c6cc-11ea-910e-e7905d5fffef.png";>
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   - unit tests pass
   - can filter on charts, dashboards, datasets list views
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI: Behind `ENABLE_REACT_CRUD_VIEWS` flag
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org