etr2460 opened a new pull request #10351: URL: https://github.com/apache/incubator-superset/pull/10351
### SUMMARY Keeping my promise from https://github.com/apache/incubator-superset/pull/10275#discussion_r455311638 All these instances seemed to be acting as buttons, so i added `role="button"` to all of them. If someone thinks they're something else from this list (https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-static-element-interactions.md#case-this-element-acts-like-a-button-link-menuitem-etc) I'm happy to update here ### TEST PLAN CI, main functionality still works ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API to: @graceguo-supercat @nytai @ktmud @suddjian ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
