dpgaspar commented on a change in pull request #10401:
URL:
https://github.com/apache/incubator-superset/pull/10401#discussion_r460389693
##########
File path: superset/views/base.py
##########
@@ -256,10 +256,13 @@ def json_response(
def menu_data() -> Dict[str, Any]:
- menu = appbuilder.menu.get_data()
+ menu = []
root_path = "#"
logo_target_path = ""
- if not g.user.is_anonymous:
+ user_is_anonymous = True
+ if hasattr(g, "user") and not g.user.is_anonymous:
Review comment:
This defeats the `Public` role. `menu.get_data` is already checking if
the user is authenticated and if not gets the permissions from the `Public`
role. Is there any other blocker?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
