nytai commented on a change in pull request #10401:
URL:
https://github.com/apache/incubator-superset/pull/10401#discussion_r475003917
##########
File path: superset/templates/appbuilder/navbar.html
##########
@@ -17,40 +17,29 @@
under the License.
#}
{% set menu = appbuilder.menu %}
-{% set languages = appbuilder.languages %}
-{% set WARNING_MSG = appbuilder.app.config['WARNING_MSG'] %}
{% set app_icon_width = appbuilder.app.config['APP_ICON_WIDTH'] %}
{% set logo_target_path = appbuilder.app.config['LOGO_TARGET_PATH'] or
'/profile/{}/'.format(current_user.username) %}
{% set root_path = logo_target_path if not logo_target_path.startswith('/')
else '/superset' + logo_target_path if current_user.username is defined else
'#' %}
-<div class="navbar navbar-static-top {{menu.extra_classes}}" role="navigation">
- <div class="container-fluid">
- <div class="navbar-header">
- <button type="button" class="navbar-toggle" data-toggle="collapse"
data-target=".navbar-collapse">
- <span class="icon-bar"></span>
- <span class="icon-bar"></span>
- <span class="icon-bar"></span>
- </button>
- <a class="navbar-brand" href="{{ root_path }}">
- <img
- width="{{ app_icon_width }}"
- src="{{ appbuilder.app_icon }}"
- alt="{{ appbuilder.app_name }}"
- />
- </a>
- </div>
- <div class="navbar-collapse collapse">
- <ul class="nav navbar-nav">
- {% if WARNING_MSG %}
- <li class="alert alert-danger">
- {{ WARNING_MSG | safe }}
- </li>
- {% endif %}
- {% include 'appbuilder/navbar_menu.html' %}
- </ul>
- <ul class="nav navbar-nav navbar-right">
- {% include 'appbuilder/navbar_right.html' %}
- </ul>
+{% block navbar %}
+ <div id="app-menu">
+ <div class="navbar navbar-static-top {{menu.extra_classes}}"
role="navigation">
Review comment:
serves as a placeholder while the menu app initializes and mounts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
