pphszx opened a new pull request #10450:
URL: https://github.com/apache/incubator-superset/pull/10450


   ### SUMMARY
   The new excel sheet upload feature is not working, this issue is reported in 
https://github.com/apache/incubator-superset/pull/9825#issuecomment-661490394, 
this PR fixes it with come changes specific to pandas.read_excel.
   
   e.g. args of chunksize, skipinitialspace are not supported, parse_dates is 
supported by both, filename arg is io, not filepath_or_buffer, which is for 
read_csv. sheet_name could be string, but integer should be more common.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   ### TEST PLAN
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to