villebro edited a comment on pull request #10450: URL: https://github.com/apache/incubator-superset/pull/10450#issuecomment-664968964
Thanks @pphszx for the fix! The security manager methods were probably renamed while the original Excel upload PR was under review, hence this error sneaked in. See @10031 for details. Are all the changes here necessary for making this work? If possible, I'd prefer to keep the changes to a minimum, and then follow up with a cleanup PR to add robustness. Not sure if you're aware, but we'll be releasing `0.37.0` soon, and it would be great to get this feature working for that release. Ping @blcksrx : as you have most context, you're probably the best person to review this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
