[GitHub] [incubator-superset] ktmud commented on a change in pull request #10302: style: DOCTYPE tag, and related CSS cleanup/refactoring

Sun, 02 Aug 2020 22:43:02 -0700 


ktmud commented on a change in pull request #10302:
URL: 
https://github.com/apache/incubator-superset/pull/10302#discussion_r464204111



##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -113,13 +126,12 @@ class ExploreChartPanel extends React.PureComponent {
         chart={this.props.chart}
       />
     );
+
     return (
-      <div className="chart-container">
-        <Panel style={{ height: this.props.height }}>
-          <Panel.Heading>{header}</Panel.Heading>
-          <Panel.Body>{this.renderChart()}</Panel.Body>
-        </Panel>
-      </div>
+      <Styles className="chart-container">
+        <div>{header}</div>
+        <div>{this.renderChart()}</div>
+      </Styles>

Review comment:
       @rusackas by not using the `Panel` component, you also missed some CSS 
styles for `.panel-header` and `panel-body`.
   
   ### After
   
   
![image](https://user-images.githubusercontent.com/335541/89149455-5b3b6180-d511-11ea-855f-52f41888e472.png)
   
   ### Before
   
   
![image](https://user-images.githubusercontent.com/335541/89149475-6db59b00-d511-11ea-8aca-e87147384a64.png)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to