ktmud commented on a change in pull request #10302:
URL:
https://github.com/apache/incubator-superset/pull/10302#discussion_r464205991
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -113,13 +126,12 @@ class ExploreChartPanel extends React.PureComponent {
chart={this.props.chart}
/>
);
+
return (
- <div className="chart-container">
- <Panel style={{ height: this.props.height }}>
- <Panel.Heading>{header}</Panel.Heading>
- <Panel.Body>{this.renderChart()}</Panel.Body>
- </Panel>
- </div>
+ <Styles className="chart-container">
+ <div>{header}</div>
+ <div>{this.renderChart()}</div>
+ </Styles>
Review comment:
Just pushed a
[fix](https://github.com/apache/incubator-superset/pull/10505). I'm using the
raw boostrap classes for now. Let's refactor it into Antd components or a more
self-contained styled component in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
