graceguo-supercat edited a comment on pull request #10475: URL: https://github.com/apache/incubator-superset/pull/10475#issuecomment-668182336
@ktmud All dashboard component has prop `isComponentVisible`, which is updated when user switch tab, and tab(s) might be nested inside another tab: https://github.com/apache/incubator-superset/blob/5b07c8d22901b7b173bd90f185904ea5c28bdad6/superset-frontend/src/dashboard/containers/DashboardComponent.jsx#L56 Chart will trigger new query (and render if necessary) according to this prop: https://github.com/apache/incubator-superset/blob/5fa46804473ad1b3909aaef4bc1d4e729c048882/superset-frontend/src/dashboard/components/gridComponents/Chart.jsx#L116 Could you check if table viz correctly update its props when it should (switch tab after apply filter)? `slightly more chart repainting` is a very dangerous sign, because some viz type's render took pretty long, and all chart's render is blocking, which means it might cause browser freeze. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
