ktmud commented on pull request #10475: URL: https://github.com/apache/incubator-superset/pull/10475#issuecomment-668469454
Here's a bit more explanation: https://github.com/apache-superset/superset-ui/pull/703 Basically when `isComponentVisible` is updated and the new active tab rendered, it might still not have been mounted to the DOM, because of the tab switch animation. The new table chart (and previously the world map) relies on rendered elements' `clientHeight` and `clientWidth` to compute the layout, which would not be available if the tab is not fully mounted. The old table chart didn't need this because it recomputes layout completely after React's rendering lifecycle. You'd notice it being "jumpier" than the current table chart. This fix is more robust as it fixes the bug for any future visualizations that need element dimensions on the fly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
