[GitHub] [incubator-superset] riahk opened a new pull request #10510: feat: add favorite star to dashboard and chart lists

[GitBox]

riahk opened a new pull request #10510:
URL: https://github.com/apache/incubator-superset/pull/10510


   ### SUMMARY
   - [x] Use svg for `FaveStar` icon and convert to TypeScript
   - [x] Fix button alignment on individual chart/dashboard header view
   - [x] Add favorite star to cells in dashboard and chart lists
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   <img width="538" alt="Screen Shot 2020-08-03 at 5 04 33 PM" 
src="https://user-images.githubusercontent.com/8216382/89238769-11538980-d5ac-11ea-8b45-e3fb73adbaa3.png";>
   <img width="823" alt="Screen Shot 2020-08-03 at 5 05 01 PM" 
src="https://user-images.githubusercontent.com/8216382/89238776-17496a80-d5ac-11ea-821a-56de63de15af.png";>
   <img width="1231" alt="Screen Shot 2020-08-03 at 5 02 40 PM" 
src="https://user-images.githubusercontent.com/8216382/89238788-20d2d280-d5ac-11ea-847e-7f557f7991e6.png";>
   <img width="1229" alt="Screen Shot 2020-08-03 at 5 04 51 PM" 
src="https://user-images.githubusercontent.com/8216382/89238793-24665980-d5ac-11ea-82e2-938784e54574.png";>
   
   After:
   <img width="969" alt="Screen Shot 2020-08-03 at 5 08 39 PM" 
src="https://user-images.githubusercontent.com/8216382/89238819-3b0cb080-d5ac-11ea-842b-1a032cc12016.png";>
   <img width="814" alt="Screen Shot 2020-08-03 at 5 00 08 PM" 
src="https://user-images.githubusercontent.com/8216382/89238828-41029180-d5ac-11ea-846b-f5d94726ec16.png";>
   <img width="1227" alt="Screen Shot 2020-08-03 at 5 00 28 PM" 
src="https://user-images.githubusercontent.com/8216382/89238833-45c74580-d5ac-11ea-8853-64158fdc682d.png";>
   <img width="1227" alt="Screen Shot 2020-08-03 at 4 59 24 PM" 
src="https://user-images.githubusercontent.com/8216382/89238838-48c23600-d5ac-11ea-8f18-f4861d3990a0.png";>
   
   ### TEST PLAN
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org