nytai commented on a change in pull request #10510:
URL:
https://github.com/apache/incubator-superset/pull/10510#discussion_r465245975
##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
##########
@@ -106,6 +110,61 @@ class DashboardList extends React.PureComponent<Props,
State> {
initialSort = [{ id: 'changed_on_delta_humanized', desc: true }];
columns = [
+ {
+ Cell: ({ row: { original } }: any) => {
+ // TODO: return null if no user is logged in
+ const fetchFaveStar = (id: number) => {
Review comment:
let's move these function definitions out of this function. Looks like
they're pretty similar in both charts and dashboards (only a url change). Can
we find a way to reuse this code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
