mistercrunch commented on a change in pull request #10510:
URL:
https://github.com/apache/incubator-superset/pull/10510#discussion_r465475834
##########
File path: superset-frontend/src/components/FaveStar.tsx
##########
@@ -0,0 +1,88 @@
+/**
Review comment:
nit (optional): for next time, let's use `git mv` when moving from `jsx`
to `tsx` so that the file's git history stays attached to it. Now you're on the
`git blame` for all the lines in the code :)
##########
File path: superset-frontend/src/components/FaveStar.tsx
##########
@@ -0,0 +1,88 @@
+/**
Review comment:
nit (optional): for next time, let's use `git mv` when moving from `jsx`
to `tsx` so that the file's git history stays attached to it. Now you're on the
`git blame` for all the lines in the file :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
