villebro opened a new pull request #10548:
URL: https://github.com/apache/incubator-superset/pull/10548


   ### SUMMARY
   Currently expected exceptions in visualization queries are not correctly 
caught, leading to a large number of unnecessary false positives on monitoring 
systems. This catches typical exceptions (e.g. `TemplateError`) and reraises 
them as `QueryObjectValidationError` (extends `SupersetException`) with more 
context, which are later caught and sent to the frontend without exception 
logging in the backend.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
![image](https://user-images.githubusercontent.com/33317356/89620818-dc3f8380-d898-11ea-84a3-c6b076f34cb1.png)
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Local testing with both legacy and new charts + ensure that no exceptions 
are logged
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to