dpgaspar commented on a change in pull request #10548:
URL:
https://github.com/apache/incubator-superset/pull/10548#discussion_r466935536
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1193,13 +1234,13 @@ def fetch_metadata(self, commit: bool = True) -> None:
"""Fetches the metadata for the table and merges it in"""
try:
table_ = self.get_sqla_table_object()
- except Exception as ex:
- logger.exception(ex)
- raise Exception(
+ except Exception:
Review comment:
`SQLAlchemyError` would be nice, but riskier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]