[GitHub] [incubator-superset] etr2460 opened a new pull request #10630: feat: add certification to metrics

[GitBox]

etr2460 opened a new pull request #10630:
URL: https://github.com/apache/incubator-superset/pull/10630


   ### SUMMARY
   Makes use of the extra column in `sql_metrics` to add certification labels 
to metrics. This shows the certification label in the datasource editor, and 
future work will add it to the metric control in superset-ui.
   
   further implementation of 
https://github.com/apache/incubator-superset/issues/10591
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="1137" alt="Screen Shot 2020-08-18 at 1 01 46 PM" 
src="https://user-images.githubusercontent.com/7409244/90561982-61a71b80-e156-11ea-88d2-699629293cb8.png";>
   <img width="781" alt="Screen Shot 2020-08-18 at 12 59 35 PM" 
src="https://user-images.githubusercontent.com/7409244/90561986-62d84880-e156-11ea-913f-22bc49bf31e6.png";>
   <img width="352" alt="Screen Shot 2020-08-18 at 12 59 44 PM" 
src="https://user-images.githubusercontent.com/7409244/90561987-62d84880-e156-11ea-8d03-34f02d07ce3a.png";>
   
   
   ### TEST PLAN
   - No icon appears when no certifiers or details are set
   - An icon appears when either a certifier or certification detail is set
   - Modifying the json string in the FAB CRUD view also works
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   to: @nytai @graceguo-supercat @mistercrunch @serenajiang 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org