etr2460 commented on a change in pull request #10630:
URL:
https://github.com/apache/incubator-superset/pull/10630#discussion_r473193392
##########
File path: superset-frontend/src/CRUD/Field.jsx
##########
@@ -32,7 +32,7 @@ import './crud.less';
const propTypes = {
value: PropTypes.any.isRequired,
label: PropTypes.string.isRequired,
- descr: PropTypes.node,
Review comment:
why make this shorter and less clear? Turns out because this file is
JSX, some usages of this component set the `description` prop, which doesn't
even work!
I've cleaned it all up to use `description` instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
