mistercrunch commented on a change in pull request #10606:
URL:
https://github.com/apache/incubator-superset/pull/10606#discussion_r472674990
##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -163,31 +176,59 @@ function ListViewCard({
<GradientContainer>
<CardCoverImg
src={imgURL}
- onError={e => {
- e.currentTarget.src = imgFallbackURL;
- }}
+ fallback={imgFallbackURL}
+ isLoading={loading}
/>
</GradientContainer>
</a>
<CoverFooter className="cover-footer">
- {coverLeft && <CoverFooterLeft>{coverLeft}</CoverFooterLeft>}
- {coverRight && <CoverFooterRight>{coverRight}</CoverFooterRight>}
+ {!loading && coverLeft && (
+ <CoverFooterLeft>{coverLeft}</CoverFooterLeft>
+ )}
+ {!loading && coverRight && (
+ <CoverFooterRight>{coverRight}</CoverFooterRight>
+ )}
</CoverFooter>
</Cover>
}
>
- <Card.Meta
- title={
- <>
- <TitleContainer>
- <TitleLink href={url}>{title}</TitleLink>
- {titleRight && <div className="title-right"> {titleRight}</div>}
- <div className="card-actions">{actions}</div>
- </TitleContainer>
- </>
- }
- description={description}
- />
+ {loading && (
+ <Card.Meta
+ title={
+ <>
+ <TitleContainer>
+ <Skeleton.Input active style={{ width: 250 }} size="small" />
Review comment:
NIT: class or constant. double diamonds `{{ ... }}` are generally
suboptimal as they get re-created on each render and also trigger re-render in
PureComponents (are they still popular?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
