nytai commented on a change in pull request #10606:
URL:
https://github.com/apache/incubator-superset/pull/10606#discussion_r473248620
##########
File path: superset-frontend/package.json
##########
@@ -266,6 +266,7 @@
"less": "^3.9.0",
"less-loader": "^5.0.0",
"mini-css-extract-plugin": "^0.4.0",
+ "node-fetch": "^2.6.0",
Review comment:
I'm not in favor of hacking in json comments. This is installed under
devDependencies and the git blame should be enough to trace the change back to
this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
