etr2460 commented on a change in pull request #10630:
URL:
https://github.com/apache/incubator-superset/pull/10630#discussion_r473430007
##########
File path: superset/connectors/sqla/models.py
##########
@@ -391,6 +394,38 @@ def lookup_obj(lookup_metric: SqlMetric) -> SqlMetric:
return import_datasource.import_simple_obj(db.session, i_metric,
lookup_obj)
+ @property
+ def is_certified(self) -> bool:
+ try:
+ extra_object = json.loads(self.extra)
Review comment:
also, looking at other models that do this, we don't bother with the
optimization of only parsing once on init
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
