villebro commented on a change in pull request #10645:
URL:
https://github.com/apache/incubator-superset/pull/10645#discussion_r474536732
##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -353,14 +353,9 @@ export class DatasourceEditor extends React.PureComponent {
syncMetadata() {
const { datasource } = this.state;
- // Handle carefully when the schema is empty
- const endpoint =
- `/datasource/external_metadata/${
- datasource.type || datasource.datasource_type
- }/${datasource.id}/` +
- `?db_id=${datasource.database.id}` +
- `&schema=${datasource.schema || ''}` +
- `&table_name=${datasource.datasource_name || datasource.table_name}`;
+ const endpoint = `/datasource/external_metadata/${
+ datasource.type || datasource.datasource_type
+ }/${datasource.id}/`;
Review comment:
With the simplification of the code in the endpoint, the slightly
hackish query params (`db_id`, `schema` and `table_name`) are now redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
