villebro commented on a change in pull request #10645:
URL:
https://github.com/apache/incubator-superset/pull/10645#discussion_r474631415
##########
File path: superset/db_engine_specs/base.py
##########
@@ -929,23 +929,25 @@ def _truncate_label(cls, label: str) -> str:
@classmethod
def column_datatype_to_string(
- cls, sqla_column_type: TypeEngine, dialect: Dialect
+ cls, column_type: Union[TypeEngine, str], dialect: Dialect
Review comment:
@bkyryliuk it appears the the `get_columns()` method in the Presto spec
is sometimes returning types as strings and not native Sql Alchemy type
objects, which was causing my new tests to fail (see comment below). Which made
me wonder how we hadn't bumped into this problem before, as this method should
be called every time we add a new table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
