amitNielsen commented on a change in pull request #10594:
URL:
https://github.com/apache/incubator-superset/pull/10594#discussion_r477602665
##########
File path: tests/dashboards/utils.py
##########
@@ -0,0 +1,37 @@
+from superset import security_manager
+
+
Review comment:
this should be DashboardTestUtilsClass where you not only have all
existing methods you also manage local state of created dashboards and
dashboardRoles and permissions so you can clean after every test/alltests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
