amitNielsen commented on a change in pull request #10594:
URL:
https://github.com/apache/incubator-superset/pull/10594#discussion_r477604750
##########
File path: superset/security/manager.py
##########
@@ -985,3 +1074,21 @@ def get_rls_ids(self, table: "BaseDatasource") ->
List[int]:
ids = [f.id for f in self.get_rls_filters(table)]
ids.sort() # Combinations rather than permutations
return ids
+
+ def del_role(self, name: str) -> bool:
Review comment:
should this method be on security manager?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
