villebro commented on a change in pull request #10733:
URL:
https://github.com/apache/incubator-superset/pull/10733#discussion_r479736327
##########
File path: superset/db_engine_specs/base.py
##########
@@ -441,17 +441,6 @@ def set_or_update_query_limit(cls, sql: str, limit: int)
-> str:
parsed_query = sql_parse.ParsedQuery(sql)
return parsed_query.set_or_update_query_limit(limit)
- @staticmethod
- def excel_to_df(**kwargs: Any) -> pd.DataFrame:
- """ Read excel into Pandas DataFrame
- :param kwargs: params to be passed to DataFrame.read_excel
- :return: Pandas DataFrame containing data from excel
- """
- kwargs["encoding"] = "utf-8"
- kwargs["iterator"] = True
Review comment:
`encoding` and `iterator` are not supported on `read_excel`:
https://pandas.pydata.org/docs/reference/api/pandas.read_excel.html#pandas.read_excel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
