villebro commented on a change in pull request #10733:
URL:
https://github.com/apache/incubator-superset/pull/10733#discussion_r479736438
##########
File path: superset/db_engine_specs/base.py
##########
@@ -521,7 +510,7 @@ def create_table_from_excel( # pylint:
disable=too-many-arguments
Create table from contents of a excel. Note: this method does not
create
metadata for the table.
"""
- df = cls.excel_to_df(io=filename, **excel_to_df_kwargs,)
+ df = pd.read_excel(io=filename, **excel_to_df_kwargs)
Review comment:
Removing method `excel_to_df` as it no longer does anything beyond
calling `pd.read_excel()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
