riahk commented on a change in pull request #10705:
URL:
https://github.com/apache/incubator-superset/pull/10705#discussion_r480301608
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseList.tsx
##########
@@ -17,52 +17,68 @@
* under the License.
*/
import { SupersetClient } from '@superset-ui/connection';
+import styled from '@superset-ui/style';
import { t } from '@superset-ui/translation';
-import React, { useEffect, useState } from 'react';
+import React, { useState, useMemo } from 'react';
+import { useListViewResource } from 'src/views/CRUD/hooks';
import { createErrorHandler } from 'src/views/CRUD/utils';
import withToasts from 'src/messageToasts/enhancers/withToasts';
+import ConfirmStatusChange from 'src/components/ConfirmStatusChange';
import SubMenu, { SubMenuProps } from 'src/components/Menu/SubMenu';
+import TooltipWrapper from 'src/components/TooltipWrapper';
+import Icon from 'src/components/Icon';
+import ListView, { Filters } from 'src/components/ListView';
import { commonMenuData } from 'src/views/CRUD/data/common';
-import DatabaseModal, { DatabaseObject } from './DatabaseModal';
+import DatabaseModal from './DatabaseModal';
+import { DatabaseObject } from './types';
+
+const PAGE_SIZE = 25;
interface DatabaseListProps {
addDangerToast: (msg: string) => void;
addSuccessToast: (msg: string) => void;
}
+const IconBlack = styled(Icon)`
+ color: #323232;
Review comment:
```suggestion
color: ${({ theme }) => theme.colors.grayscale.dark1};
```
##########
File path: superset-frontend/src/views/CRUD/data/database/types.ts
##########
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+type DatabaseUser = {
+ first_name: string;
+ last_name: string;
+};
+
+export type DatabaseObject = {
Review comment:
Not sure how we want to hand the `DatabaseObject` between the list and
the modal; especially since the modal has some extra fields, I'm not sure if we
want to include those as optional props or just create a second type to use in
the modal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
