nytai commented on a change in pull request #10705:
URL:
https://github.com/apache/incubator-superset/pull/10705#discussion_r480468507
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseList.tsx
##########
@@ -96,6 +270,18 @@ function DatabaseList({ addDangerToast, addSuccessToast }:
DatabaseListProps) {
/* TODO: add database logic here */
}}
/>
+
+ <ListView<DatabaseObject>
Review comment:
It allows specifying the generic for the ListView props. This means that
props like `renderCard` are not `(data: any) => ReactNode` and are instead
`(data: DatabaseObject) => ReactNode`.
You can read more about it here:
https://mariusschulz.com/articles/passing-generics-to-jsx-elements-in-typescript
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
