dpgaspar commented on a change in pull request #10875:
URL:
https://github.com/apache/incubator-superset/pull/10875#discussion_r488690083
##########
File path: requirements/development.in
##########
@@ -14,6 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
+-r base.txt
Review comment:
Updated but, like we already discussed this is debatable also:
Pros:
- Running `pip-compile-multi` to upgrade packages will just work.
Currently we have to fix clashes manually.
Cons:
- `base.txt` and `development.txt` will slowly start to diverge. One
could ask, whats the use for `base.txt`
- CI tests and docker will be based on `development.txt` and in time we
will not guarantee these will be the same has the declared dependencies on
`base.txt`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
