dpgaspar commented on pull request #10875: URL: https://github.com/apache/incubator-superset/pull/10875#issuecomment-692790933
> Sorry there’s a few things I don’t understand: > > 1. Why is `mysqlclient` not allowed in `base.txt` but is allowed in `setup.py`? Both files are included in the manifest as far as I’m aware. > 2. I’m not sure why `integration.in` was incorporated into `development.in`. By definition this should contain the subset of packages required only to define the base integration environment for CI et al. and should be agnostic of Superset. 1 - `mysqlclient` is allowed on `setup.py` has an extra requirement, so our goal here is to make a Apache license compliant requirements file 2 - Yes that's a good point, I can re include `integration.in` has it was, and still have a `development.in` with all the necessary extras. Extra question: Should we base `development.in` on `base.in` or branch it directly from `setup.py` to include the extras (like it's currently done on this PR) ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
