eschutho commented on a change in pull request #10897:
URL:
https://github.com/apache/incubator-superset/pull/10897#discussion_r489073995
##########
File path: superset-frontend/src/dashboard/util/getComponentWidthFromDrop.js
##########
@@ -50,7 +50,7 @@ export default function getComponentWidthFromDrop({
let destinationCapacity =
destinationWidth.width - destinationWidth.occupiedWidth;
- if (Number.isNaN(destinationCapacity)) {
+ if (Number.isNaN(Number(destinationCapacity))) {
Review comment:
It looks to me that you still want to return the original value as
defined if it's not a number. If I coerce them earlier, you're going to get NaN
as a value. I'm reading through the code now to see if that will work, but
you're probably more familiar with the code than I am.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
