ktmud commented on a change in pull request #10897:
URL:
https://github.com/apache/incubator-superset/pull/10897#discussion_r489080112
##########
File path: superset-frontend/src/dashboard/util/getComponentWidthFromDrop.js
##########
@@ -50,7 +50,7 @@ export default function getComponentWidthFromDrop({
let destinationCapacity =
destinationWidth.width - destinationWidth.occupiedWidth;
- if (Number.isNaN(destinationCapacity)) {
+ if (Number.isNaN(Number(destinationCapacity))) {
Review comment:
I actually know nothing about this file, lol. Just took another look,
for `destinationCapacity` at least, it's calculated from an arithmetic
operation so it's definitely expected to be a number.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
