ktmud commented on pull request #10971: URL: https://github.com/apache/incubator-superset/pull/10971#issuecomment-695911225
Overall great improvements! But I'm a little worried that the interaction with DatasourceControl may have become a little more confusing. The gray pill looks the same like the clickable labels in other controls (Viz Type and Time Range) but is not actually clickable. Using the cog icon for a dropdown menu also seems a little anti-pattern. What do you think of keeping it as a dropdown menu and limiting this PR to just changing the style? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
