mistercrunch edited a comment on pull request #10971: URL: https://github.com/apache/incubator-superset/pull/10971#issuecomment-696274724
@JunlinC I tagged `design-review` for input! Happy to consider other approaches that address the underlying motives. About the motives, I think the recently tweaked default <Label> is way too dark and "pops" way too much in this current state. The previous "white on a lighter gray" had usability issues, so I figure I'd go "black on light-gray with a light border" and it looks much better to me than before. More generally, I'm not sure if the label-with-popover pattern for controls is the right approach. I'd be curious to see how it would look if we'd redesign it from scratch. Open to suggestion & tweaks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
