rusackas commented on a change in pull request #11102:
URL:
https://github.com/apache/incubator-superset/pull/11102#discussion_r497975361
##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -69,15 +68,24 @@ type MenuChild = {
usesRouter?: boolean;
};
+export enum ButtonStyleTypes {
+ Primary = 'primary',
+ Secondary = 'secondary',
+ Dashed = 'dashed',
+ Danger = 'danger',
+ Link = 'link',
+ Warning = 'warning',
+ Success = 'success',
+}
+
+interface ButtonProps {
+ name: any;
+ onClick: OnClickHandler;
+ style: ButtonStyleTypes;
Review comment:
NOT, but it might actually be good to call it `buttonStyle` instead of
`style`, lest people think it's something CSS related. Also, further down in
the code, you would then have `buttonStyle={btn.buttonStyle}` if that feels
more aligned at all :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
