pkdotson commented on a change in pull request #11102:
URL:
https://github.com/apache/incubator-superset/pull/11102#discussion_r498395924
##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -69,15 +68,24 @@ type MenuChild = {
usesRouter?: boolean;
};
+export enum ButtonStyleTypes {
+ Primary = 'primary',
+ Secondary = 'secondary',
+ Dashed = 'dashed',
+ Danger = 'danger',
+ Link = 'link',
+ Warning = 'warning',
+ Success = 'success',
+}
+
+interface ButtonProps {
+ name: any;
+ onClick: OnClickHandler;
+ style: ButtonStyleTypes;
Review comment:
I tried doing this but it didn't like the assignment when doing `style:<
whatever defined string>` in the button. I'll play around with it more and see
what i'm missing...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
