villebro commented on a change in pull request #11131:
URL:
https://github.com/apache/incubator-superset/pull/11131#discussion_r499608860
##########
File path: tests/security_tests.py
##########
@@ -1122,6 +1132,41 @@ def test_rls_filter_doesnt_alter_energy_query(self):
assert tbl.get_extra_cache_keys(self.query_obj) == []
assert "value > 1" not in sql
+ @pytest.fixture()
+ def load_unicode_dashboard(self):
Review comment:
@kkucharc you are right, I meant the `fixtures/` directory! Perhaps we
could create something like `fixtures/unicode.py` that would for now just
include `def load_unicode_dashboard()`. Down the road I actually think it would
be great to try to decouple datasets, charts and dashboards from each other, as
may backend tests don't necessarily need the full suite of charts and
dashboards, but are ok with just the dataset. Having said that, let's take
gradual steps here, so as to not choke on trying to make this perfect on first
iteration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
