kkucharc commented on a change in pull request #11131:
URL:
https://github.com/apache/incubator-superset/pull/11131#discussion_r499742930
##########
File path: tests/security_tests.py
##########
@@ -1122,6 +1132,41 @@ def test_rls_filter_doesnt_alter_energy_query(self):
assert tbl.get_extra_cache_keys(self.query_obj) == []
assert "value > 1" not in sql
+ @pytest.fixture()
+ def load_unicode_dashboard(self):
Review comment:
That makes sens. I refactored this part. To be honest, I'm proud of this
:) - I hope this will be good step on first iteration of this refactor. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
