rusackas commented on a change in pull request #11134:
URL:
https://github.com/apache/incubator-superset/pull/11134#discussion_r501297231
##########
File path: superset-frontend/src/explore/components/PropertiesModal.tsx
##########
@@ -159,7 +159,7 @@ function PropertiesModal({ slice, onHide, onSave }:
InternalProps) {
return (
<form onSubmit={onSubmit}>
- <Modal.Header closeButton>
+ <Modal.Header data-test="edit-modal" closeButton>
Review comment:
Could be more specific (i.e. 'edit-properties-modal') if you can expect
there to be more than one instance of modal in the code with
`data-test="edit-modal"` - it just makes it easier to find the instance in the
codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
