rusackas commented on a change in pull request #11134:
URL:
https://github.com/apache/incubator-superset/pull/11134#discussion_r501299963
##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
##########
@@ -293,7 +293,10 @@ function DashboardList(props: DashboardListProps) {
className="action-button"
onClick={confirmDelete}
>
- <Icon name="trash" />
+ <Icon
+ {...{ 'data-test': 'dashboard-list-trash-icon' }}
Review comment:
Wondering again about the need spread syntax over the attribute, which
could be stripped out by babel for sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
