adam-stasiak opened a new pull request #11238:
URL: https://github.com/apache/incubator-superset/pull/11238


   …ev script
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   I was not able to perform successful hot-reload while running npm run dev 
script in docker. Change was applied in tsx file in container but UI did not 
show this change applied without restarting. I added an option to possibly run 
npm run dev-server while using docker-compose up setup.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   Pull branch
   Run ```ENABLE_WEBPACK_DEV_SERVER=yes docker-compose up```
   Wait for webpack to be finished
   Modify local file and save
   On UI observe if change was applied
   
   Expected result: It should be no any other action needed than page reload 
after save.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to