mistercrunch commented on a change in pull request #11222: URL: https://github.com/apache/incubator-superset/pull/11222#discussion_r504364998
########## File path: superset/utils/log.py ########## @@ -36,58 +36,69 @@ def log( ) -> None: pass - def log_this(self, f: Callable[..., Any]) -> Callable[..., Any]: + def log_with_context( Review comment: Eventually we can add a context manager (allowing the `with` clause in python) so that we can do things like: ```python with log_this_with_duration(action="do_stuff"): do_stuff_that_takes_long() ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org