ktmud commented on a change in pull request #11222:
URL:
https://github.com/apache/incubator-superset/pull/11222#discussion_r504484382
##########
File path: superset/utils/log.py
##########
@@ -36,58 +36,69 @@ def log(
) -> None:
pass
- def log_this(self, f: Callable[..., Any]) -> Callable[..., Any]:
+ def log_with_context(
Review comment:
Refactored with `contextmanager`. Didn't use `contextlib2` since it
seems to be a backport package for older pythons (<3.6) which we no longer
support. Plus we also didn't use the advanced stuff it was trying to backport.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
