zhaoyongjie commented on a change in pull request #11233:
URL:
https://github.com/apache/incubator-superset/pull/11233#discussion_r504435115
##########
File path: superset/db_engine_specs/__init__.py
##########
@@ -49,3 +50,6 @@
and attribute.engine != ""
):
engines[attribute.engine] = attribute
+ if attribute.engine in _translates:
+ _dialect = _translates[attribute.engine]
+ engines[_dialect] = attribute
Review comment:
Nice suggestion! I will implement this soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
